Discussion:
[PATCH] nfs: Fix error path in nfs_options_qdict_to_qapi()
(too old to reply)
Kevin Wolf
2018-05-16 16:10:34 UTC
Permalink
Don't throw away local_err, but propagate it to errp.

Signed-off-by: Kevin Wolf <***@redhat.com>
---
block/nfs.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/block/nfs.c b/block/nfs.c
index d6364d28bb..3349b67a76 100644
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -571,6 +571,7 @@ static BlockdevOptionsNfs *nfs_options_qdict_to_qapi(QDict *options,
qobject_unref(crumpled);

if (local_err) {
+ error_propagate(errp, local_err);
return NULL;
}
--
2.13.6
Eric Blake
2018-05-16 16:49:00 UTC
Permalink
Post by Kevin Wolf
Don't throw away local_err, but propagate it to errp.
---
block/nfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/nfs.c b/block/nfs.c
index d6364d28bb..3349b67a76 100644
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -571,6 +571,7 @@ static BlockdevOptionsNfs *nfs_options_qdict_to_qapi(QDict *options,
qobject_unref(crumpled);
if (local_err) {
+ error_propagate(errp, local_err);
return NULL;
}
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
Jeff Cody
2018-05-16 17:10:38 UTC
Permalink
Post by Kevin Wolf
Don't throw away local_err, but propagate it to errp.
---
block/nfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/nfs.c b/block/nfs.c
index d6364d28bb..3349b67a76 100644
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -571,6 +571,7 @@ static BlockdevOptionsNfs *nfs_options_qdict_to_qapi(QDict *options,
qobject_unref(crumpled);
if (local_err) {
+ error_propagate(errp, local_err);
return NULL;
}
--
2.13.6
Thanks,

Applied to my block branch:

git://github.com/codyprime/qemu-kvm-jtc block

-Jeff

Loading...